Allow assigning to users on vacation#1920
Closed
Noratrieb wants to merge 2 commits intorust-lang:masterfrom
Closed
Allow assigning to users on vacation#1920Noratrieb wants to merge 2 commits intorust-lang:masterfrom
Noratrieb wants to merge 2 commits intorust-lang:masterfrom
Conversation
If someone assigns a person directly, they probably know what they want, don't filter anything. Let someone assign the author, someone on vacation, or an already assigned reviewer. This is important because of the vacation part, we want people to be able to assign people on vacation.
People on vacation will usually not (they better >:() respond during their vacation, but they probably will be able to respond after. There is no reason why you wouldn't be able to assign to someone on vacation manually if this person is the best reviewer and you have enough patience for them to return, so don't prevent it. Do print a warning though to set expectations for both the author and triage.
Kobzol
reviewed
Mar 31, 2025
| if filter(&group_or_user) { | ||
| candidates.insert(group_or_user); | ||
| } | ||
| candidates.insert(group_or_user); |
Member
There was a problem hiding this comment.
Hmm, but this tests more things than just vacation, right? 🤔
Member
Author
There was a problem hiding this comment.
Yes, it also detects author assignment and re-assignment, which I think are fine to allow for direct assignments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
People on vacation will usually not (they better >:() respond during their vacation, but they probably will be able to respond after. There is no reason why you wouldn't be able to assign to someone on vacation manually if this person is the best reviewer and you have enough patience for them to return, so don't prevent it. Do print a warning though to set expectations for both the author and triage.
If someone wants to be completely unassignable because they have left, they'll already be unassignable because they have left.
docs: rust-lang/rust-forge#821